Mod:refactor to add base_registry #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hxmhlt
requested review from
pantianying,
flycash,
AlexStocks and
fangyincheng
Codecov Report
@@ Coverage Diff @@
## develop #348 +/- ##
===========================================
- Coverage 67.65% 67.14% -0.51%
===========================================
Files 123 145 +22
Lines 7317 7692 +375
===========================================
+ Hits 4950 5165 +215
- Misses 1894 2037 +143
- Partials 473 490 +17
Continue to review full report at Codecov.
|
flycash
reviewed
Feb 3, 2020
pantianying
reviewed
Feb 3, 2020
|
Can you remove the recursive logic from the zookeeper registry center in this PR，distinguish from configuration center😛😘 |
Yes，I run it in dubbo-samples |
I think it will be another pr. We need to create a new pull request to do that. |
zouyx
approved these changes
Feb 7, 2020
AlexStocks
reviewed
Feb 7, 2020
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: